Skip to content

Creating an expandable enum type, converting StorageClass - #1937

Merged
garrettjonesgoogle merged 3 commits into
googleapis:masterfrom
garrettjonesgoogle:alt
Apr 18, 2017
Merged

Creating an expandable enum type, converting StorageClass#1937
garrettjonesgoogle merged 3 commits into
googleapis:masterfrom
garrettjonesgoogle:alt

Conversation

@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

Design notes:

  • I made it so that converting an enum into a StorageEnumValue is not disruptive at a code level (e.g. it has valueOf and values, same as Java enums)
  • I am only converting one enum now, and after we agree on the design, I will do a follow-up PR to convert the rest.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants